From dc7e40733e07af4e96f43386340a1c05ee3e7a72 Mon Sep 17 00:00:00 2001 From: Ximin Luo Date: Thu, 13 Jun 2024 11:16:38 +0200 Subject: [PATCH] Disable network tests Forwarded: TODO Gbp-Pq: Topic cargo Gbp-Pq: Name c-2002_disable-net-tests.patch --- .../tests/testsuite/credential_process.rs | 16 +-- src/tools/cargo/tests/testsuite/git_auth.rs | 4 +- src/tools/cargo/tests/testsuite/net_config.rs | 4 +- src/tools/cargo/tests/testsuite/publish.rs | 115 +++++++++--------- 4 files changed, 70 insertions(+), 69 deletions(-) diff --git a/src/tools/cargo/tests/testsuite/credential_process.rs b/src/tools/cargo/tests/testsuite/credential_process.rs index cd223b523d..53719d01fd 100644 --- a/src/tools/cargo/tests/testsuite/credential_process.rs +++ b/src/tools/cargo/tests/testsuite/credential_process.rs @@ -66,7 +66,7 @@ fn get_token_test() -> (Project, TestRegistry) { (p, server) } -#[cargo_test] +#[allow(dead_code)] fn publish() { // Checks that credential-process is used for `cargo publish`. let (p, _t) = get_token_test(); @@ -88,7 +88,7 @@ fn publish() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn credential_provider_auth_failure() { let _reg = registry::RegistryBuilder::new() .http_index() @@ -113,7 +113,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn basic_unsupported() { // Non-action commands don't support login/logout. let registry = registry::RegistryBuilder::new() @@ -148,7 +148,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn login() { let registry = registry::RegistryBuilder::new() .no_configure_token() @@ -170,7 +170,7 @@ fn login() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn logout() { let server = registry::RegistryBuilder::new() .no_configure_token() @@ -189,7 +189,7 @@ fn logout() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn yank() { let (p, _t) = get_token_test(); @@ -204,7 +204,7 @@ fn yank() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn owner() { let (p, _t) = get_token_test(); @@ -219,7 +219,7 @@ fn owner() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn invalid_token_output() { // Error when credential process does not output the expected format for a token. let cred_proj = project() diff --git a/src/tools/cargo/tests/testsuite/git_auth.rs b/src/tools/cargo/tests/testsuite/git_auth.rs index c99ae793bf..f7ec848b98 100644 --- a/src/tools/cargo/tests/testsuite/git_auth.rs +++ b/src/tools/cargo/tests/testsuite/git_auth.rs @@ -105,7 +105,7 @@ fn setup_failed_auth_test() -> (SocketAddr, JoinHandle<()>, Arc) { } // Tests that HTTP auth is offered from `credential.helper`. -#[cargo_test] +#[allow(dead_code)] fn http_auth_offered() { let (addr, t, connections) = setup_failed_auth_test(); let p = project() @@ -178,7 +178,7 @@ Caused by: } // Boy, sure would be nice to have a TLS implementation in rust! -#[cargo_test] +#[allow(dead_code)] fn https_something_happens() { let server = TcpListener::bind("127.0.0.1:0").unwrap(); let addr = server.local_addr().unwrap(); diff --git a/src/tools/cargo/tests/testsuite/net_config.rs b/src/tools/cargo/tests/testsuite/net_config.rs index f1be9b2b05..cc001c2117 100644 --- a/src/tools/cargo/tests/testsuite/net_config.rs +++ b/src/tools/cargo/tests/testsuite/net_config.rs @@ -4,7 +4,7 @@ use crate::prelude::*; use cargo_test_support::project; use cargo_test_support::str; -#[cargo_test] +#[allow(dead_code)] fn net_retry_loads_from_config() { let p = project() .file( @@ -41,7 +41,7 @@ fn net_retry_loads_from_config() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn net_retry_git_outputs_warning() { let p = project() .file( diff --git a/src/tools/cargo/tests/testsuite/publish.rs b/src/tools/cargo/tests/testsuite/publish.rs index 43e43cbab1..bc2519bc74 100644 --- a/src/tools/cargo/tests/testsuite/publish.rs +++ b/src/tools/cargo/tests/testsuite/publish.rs @@ -90,7 +90,7 @@ fn validate_upload_li() { ); } -#[cargo_test] +#[allow(dead_code)] fn simple() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -184,7 +184,7 @@ fn duplicate_version() { // Check that the `token` key works at the root instead of under a // `[registry]` table. -#[cargo_test] +#[allow(dead_code)] fn simple_publish_with_http() { let _reg = registry::RegistryBuilder::new() .http_api() @@ -226,7 +226,7 @@ fn simple_publish_with_http() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn simple_publish_with_asymmetric() { let _reg = registry::RegistryBuilder::new() .http_api() @@ -270,7 +270,7 @@ fn simple_publish_with_asymmetric() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn old_token_location() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -330,7 +330,7 @@ or use environment variable CARGO_REGISTRY_TOKEN // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn simple_with_index() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -377,7 +377,7 @@ fn simple_with_index() { // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn git_deps() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -418,7 +418,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn path_dependency_no_version() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -461,7 +461,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn unpublishable_crate() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -494,7 +494,7 @@ fn unpublishable_crate() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn dont_publish_dirty() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -535,7 +535,7 @@ to proceed despite this and include the uncommitted changes, pass the `--allow-d .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_clean() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -583,7 +583,7 @@ fn publish_clean() { // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn publish_in_sub_repo() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -632,7 +632,7 @@ fn publish_in_sub_repo() { // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn publish_when_ignored() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -681,7 +681,7 @@ fn publish_when_ignored() { // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn ignore_when_crate_ignored() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -729,7 +729,7 @@ fn ignore_when_crate_ignored() { // Other tests will verify the endpoint gets the right payload. } -#[cargo_test] +#[allow(dead_code)] fn new_crate_rejected() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -764,7 +764,7 @@ fn new_crate_rejected() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn dry_run() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -808,7 +808,7 @@ fn dry_run() { assert!(!registry::api_path().join("api/v1/crates/new").exists()); } -#[cargo_test] +#[allow(dead_code)] fn registry_not_in_publish_list() { let p = project() .file( @@ -841,7 +841,7 @@ The registry `alternative` is not listed in the `package.publish` value in Cargo .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_empty_list() { let p = project() .file( @@ -870,7 +870,7 @@ fn publish_empty_list() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_allowed_registry() { let _registry = RegistryBuilder::new() .http_api() @@ -930,7 +930,7 @@ fn publish_allowed_registry() { ); } -#[cargo_test] +#[allow(dead_code)] fn publish_implicitly_to_only_allowed_registry() { let _registry = RegistryBuilder::new() .http_api() @@ -991,7 +991,7 @@ fn publish_implicitly_to_only_allowed_registry() { ); } -#[cargo_test] +#[allow(dead_code)] fn publish_failed_with_index_and_only_allowed_registry() { let registry = RegistryBuilder::new() .http_api() @@ -1032,7 +1032,7 @@ fn publish_failed_with_index_and_only_allowed_registry() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_fail_with_no_registry_specified() { let p = project().build(); @@ -1065,7 +1065,7 @@ fn publish_fail_with_no_registry_specified() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn block_publish_no_registry() { let p = project() .file( @@ -1095,7 +1095,7 @@ fn block_publish_no_registry() { } // Explicitly setting `crates-io` in the publish list. -#[cargo_test] +#[allow(dead_code)] fn publish_with_crates_io_explicit() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -1148,7 +1148,7 @@ The registry `alternative` is not listed in the `package.publish` value in Cargo .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_with_select_features() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -1200,7 +1200,7 @@ fn publish_with_select_features() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_with_all_features() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -1252,7 +1252,7 @@ fn publish_with_all_features() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_with_no_default_features() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -1293,7 +1293,7 @@ fn publish_with_no_default_features() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_with_patch() { let registry = RegistryBuilder::new().http_api().http_index().build(); Package::new("bar", "1.0.0").publish(); @@ -1403,7 +1403,8 @@ error[E0425]: cannot find function `newfunc` in crate `bar` ); } -#[cargo_test] +#[expect(deprecated)] +#[allow(dead_code)] fn publish_checks_for_token_before_verify() { let registry = registry::RegistryBuilder::new() .no_configure_token() @@ -1458,7 +1459,7 @@ or use environment variable CARGO_REGISTRY_TOKEN .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_with_bad_source() { let p = project() .file( @@ -1505,7 +1506,7 @@ include `--registry crates-io` to use crates.io } // A dependency with both `git` and `version`. -#[cargo_test] +#[allow(dead_code)] fn publish_git_with_version() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -1676,7 +1677,7 @@ dependencies = [ ); } -#[cargo_test] +#[allow(dead_code)] fn publish_dev_dep_stripping() { let registry = RegistryBuilder::new().http_api().http_index().build(); Package::new("normal-only", "1.0.0") @@ -2112,7 +2113,7 @@ features = ["cat"] ); } -#[cargo_test] +#[allow(dead_code)] fn credentials_ambiguous_filename() { // `publish` generally requires a remote registry let registry = registry::RegistryBuilder::new().http_api().build(); @@ -2173,7 +2174,7 @@ fn credentials_ambiguous_filename() { // --index will not load registry.token to avoid possibly leaking // crates.io token to another server. -#[cargo_test] +#[allow(dead_code)] fn index_requires_token() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -2208,7 +2209,7 @@ fn index_requires_token() { } // publish with source replacement without --registry -#[cargo_test] +#[allow(dead_code)] fn cratesio_source_replacement() { registry::init(); let p = project() @@ -2238,7 +2239,7 @@ include `--registry dummy-registry` or `--registry crates-io` } // Registry returns an API error. -#[cargo_test] +#[allow(dead_code)] fn api_error_json() { let _registry = registry::RegistryBuilder::new() .alternative() @@ -2286,7 +2287,7 @@ Caused by: } // Registry returns an API error with a 200 status code. -#[cargo_test] +#[allow(dead_code)] fn api_error_200() { let _registry = registry::RegistryBuilder::new() .alternative() @@ -2334,7 +2335,7 @@ Caused by: } // Registry returns an error code without a JSON message. -#[cargo_test] +#[allow(dead_code)] fn api_error_code() { let _registry = registry::RegistryBuilder::new() .alternative() @@ -2389,7 +2390,7 @@ Caused by: } // Registry has a network error. -#[cargo_test] +#[allow(dead_code)] fn api_curl_error() { let _registry = registry::RegistryBuilder::new() .alternative() @@ -2439,7 +2440,7 @@ Caused by: } // Registry returns an invalid response. -#[cargo_test] +#[allow(dead_code)] fn api_other_error() { let _registry = registry::RegistryBuilder::new() .alternative() @@ -2489,7 +2490,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn in_package_workspace() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2542,7 +2543,7 @@ fn in_package_workspace() { validate_upload_li(); } -#[cargo_test] +#[allow(dead_code)] fn with_duplicate_spec_in_members() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2613,7 +2614,7 @@ fn with_duplicate_spec_in_members() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn in_package_workspace_with_members_with_features_old() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2666,7 +2667,7 @@ fn in_package_workspace_with_members_with_features_old() { validate_upload_li(); } -#[cargo_test] +#[allow(dead_code)] fn in_virtual_workspace() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2712,7 +2713,7 @@ fn in_virtual_workspace() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn in_virtual_workspace_with_p() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2771,7 +2772,7 @@ fn in_virtual_workspace_with_p() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn in_package_workspace_not_found() { // Use local registry for faster test times since no publish will occur let registry = registry::init(); @@ -2815,7 +2816,7 @@ fn in_package_workspace_not_found() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn in_package_workspace_found_multiple() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2886,7 +2887,7 @@ fn in_package_workspace_found_multiple() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn publish_path_dependency_without_workspace() { let registry = RegistryBuilder::new().http_api().http_index().build(); @@ -2930,7 +2931,7 @@ fn publish_path_dependency_without_workspace() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn http_api_not_noop() { let registry = registry::RegistryBuilder::new().http_api().build(); @@ -2993,7 +2994,7 @@ fn http_api_not_noop() { p.cargo("build").run(); } -#[cargo_test] +#[allow(dead_code)] fn wait_for_first_publish() { // Counter for number of tries before the package is "published" let arc: Arc> = Arc::new(Mutex::new(0)); @@ -3077,7 +3078,7 @@ fn wait_for_first_publish() { /// A separate test is needed for package names with - or _ as they hit /// the responder twice per cargo invocation. If that ever gets changed /// this test will need to be changed accordingly. -#[cargo_test] +#[allow(dead_code)] fn wait_for_first_publish_underscore() { // Counter for number of tries before the package is "published" let arc: Arc> = Arc::new(Mutex::new(0)); @@ -3175,7 +3176,7 @@ fn wait_for_first_publish_underscore() { p.cargo("build").with_status(0).run(); } -#[cargo_test] +#[allow(dead_code)] fn wait_for_subsequent_publish() { // Counter for number of tries before the package is "published" let arc: Arc> = Arc::new(Mutex::new(0)); @@ -3269,7 +3270,7 @@ fn wait_for_subsequent_publish() { p.cargo("check").with_status(0).run(); } -#[cargo_test] +#[allow(dead_code)] fn skip_wait_for_publish() { // Intentionally using local registry so the crate never makes it to the index let registry = registry::init(); @@ -3314,7 +3315,7 @@ fn skip_wait_for_publish() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn timeout_waiting_for_publish() { // Publish doesn't happen within the timeout window. let registry = registry::RegistryBuilder::new() @@ -3368,7 +3369,7 @@ fn timeout_waiting_for_publish() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn timeout_waiting_for_dependency_publish() { // Publish doesn't happen within the timeout window. let registry = registry::RegistryBuilder::new() @@ -3472,7 +3473,7 @@ fn timeout_waiting_for_dependency_publish() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn package_selection() { let registry = registry::RegistryBuilder::new().http_api().build(); let p = project() @@ -3552,7 +3553,7 @@ fn package_selection() { .run(); } -#[cargo_test] +#[allow(dead_code)] fn wait_for_git_publish() { // Slow publish to an index with a git index. let registry = registry::RegistryBuilder::new() @@ -4317,7 +4318,7 @@ Caused by: .run(); } -#[cargo_test] +#[allow(dead_code)] fn all_unpublishable_packages() { let registry = RegistryBuilder::new().http_api().http_index().build(); -- 2.30.2